Advisory

GHSA-jgm9-xpfj-4fq6

Also known as: CVE-2022-21693, PYSEC-2022-44

Summary

Path traversal in Onionshare

Details

Between September 26, 2021 and October 8, 2021, Radically Open Security conducted a penetration test of OnionShare 2.4, funded by the Open Technology Fund's Red Team lab. This is an issue from that penetration test.

  • Vulnerability ID: OTF-013
  • Vulnerability type: Improper Hardening
  • Threat level: Low

Description:

The filesystem restriction could be hardened and should only allow for pre-defined subfolders.

Technical description:

The Flatpak and Snap configurations allow for read-only access on the whole home folder. The relevant lines in the configuration files are onionshare/snap/snapcraft.yaml#L20 and onionshare/flatpak/org.onionshare.OnionShare.yaml#L19 , respectively.

The encapsulation of filesystem access via these mechanisms should be restricted to pre-defined folders and not allow for access to (configuration) files outside the Onionshare-specific folders.

Sadly Snap does not allow for further restriction to specific folders and therefore cannot be further hardened. By default both frameworks disallow access to hidden folders and therefore reduce the potential impact.

Impact:

An adversary with a primitive that allows for filesystem access from the context of the Onionshare process can access sensitive files in the entire user home folder. This could lead to the leaking of sensitive data. Due to the automatic exclusion of hidden folders, the impact is reduced.

Recommendation:

  • Reduce read access in Flatpak configuration.

Severity

Medium Basis: The source's own band: MODERATE

Dates

Published
2022-01-21 23:20 UTC
Modified
2024-10-07 21:08 UTC

Affected packages and fixes

onionshare-cli

PyPI · All systems

Affected

  • introduced 2.3, fixed 2.5 (ecosystem)

Fixed versions

2.5

Fix

  • Fixed version 2.5
    pip install --upgrade onionshare-cli==2.5

Fix commands are the export's own generic commands. Ojuju never runs them. Check them against your setup first.

Check your own computer: guard packages check

View this record on OSV.dev

Source

Source: GitHub Advisory Database (reviewed advisories) · CC BY 4.0

Sources & licences