Advisory

GHSA-m2v9-w374-5hj9

Also known as: CVE-2024-32648, PYSEC-2024-163

Summary

vyper default functions don't respect nonreentrancy keys

Details

Summary
Prior to v0.3.0, __default__() functions did not respect the @nonreentrancy decorator and the lock was not emitted. This is a known bug and was already visible in the issue tracker (https://github.com/vyperlang/vyper/issues/2455), but it is being re-issued as an advisory so that tools relying on the advisory publication list can incorporate it into their searches.

A contract search was additionally performed and no vulnerable contracts were found in production.

PoC

@external
@payable
@nonreentrant("default")
def __default__():
    pass

after codegen:

[seq,
  [if, [lt, calldatasize, 4], [goto, fallback]],
  [mstore, 28, [calldataload, 0]],
  [with, _func_sig, [mload, 0], seq],
  [seq_unchecked,
    [label, fallback],
    [seq,
      pass,
      # Line 5
      pass,
      pass,
      # Line 4
      stop]]],

Impact
No vulnerable production contracts were found. Additionally, using a lock on a default function is a very sparsely used pattern. As such, the impact is low.

Severity

Medium Basis: The source's own band: MODERATE

Dates

Published
2024-04-25 19:50 UTC
Modified
2026-06-10 17:14 UTC

Affected packages and fixes

vyper

PyPI · All systems

Affected

  • introduced 0, fixed 0.3.0 (ecosystem)

Fixed versions

0.3.0

Fix

  • Fixed version 0.3.0
    pip install --upgrade vyper==0.3.0

Fix commands are the export's own generic commands. Ojuju never runs them. Check them against your setup first.

Check your own computer: guard packages check

View this record on OSV.dev

Source

Source: GitHub Advisory Database (reviewed advisories) · CC BY 4.0

Sources & licences