Details
$ php -r '$livet=["key"=>"\" onmouseover=\"alert(1)\" x=\""]; echo "<span class=\"title_liveKey_".$livet["key"]."\">test</span>";'
<span class="title_liveKey_" onmouseover="alert(1)" x="">test</span> # XSS attribute parses
$ php -r '$livet=["key"=>"\" onmouseover=\"alert(1)\" x=\""]; echo "<span class=\"title_liveKey_".htmlspecialchars($livet["key"],ENT_QUOTES,"UTF-8")."\">test</span>";'
<span class="title_liveKey_" onmouseover="alert(1)" x="">test</span> # one attribute, no handler
Suggested Fix
Escape the key when it is rendered into the HTML attribute. The same escape should be applied wherever the key reaches HTML context (other Live templates appear safe because they only use it in JS string contexts after replace(/[&=]/g, ''), but they should be reviewed in the same patch).
--- a/plugin/Live/view/modeYoutubeLive.php
+++ b/plugin/Live/view/modeYoutubeLive.php
@@ -200,7 +200,7 @@
}
?>
- <span class="title_liveKey_<?php echo $livet['key'] ?>"><?php echo getSEOTitle($liveTitle); ?></span>
+ <span class="title_liveKey_<?php echo htmlspecialchars($livet['key'], ENT_QUOTES, 'UTF-8') ?>"><?php echo getSEOTitle($liveTitle); ?></span>
<small class="text-muted">
<?php
echo $liveInfo['displayTime'];
Defence-in-depth: also enforce a character allowlist on live_transmitions.key at write time (the autogenerator emits uniqid() which is hex-only, so ^[A-Za-z0-9_-]{1,64}$ is the natural allowlist) so that the field can never carry HTML metacharacters in the first place. That hardens any other future render site against the same primitive without a second escape audit.