Advisory

GHSA-m7wr-2xf7-cm9p

Also known as: CVE-2024-27289, GO-2024-2605

Summary

pgx SQL Injection via Line Comment Creation

Details

Impact

SQL injection can occur when all of the following conditions are met:

  1. The non-default simple protocol is used.
  2. A placeholder for a numeric value must be immediately preceded by a minus.
  3. There must be a second placeholder for a string value after the first placeholder; both

must be on the same line.

  1. Both parameter values must be user-controlled.

e.g.

Simple mode must be enabled:

// connection string includes "prefer_simple_protocol=true"
// or
// directly enabled in code
config.ConnConfig.PreferSimpleProtocol = true

Parameterized query:

SELECT * FROM example WHERE result=-$1 OR name=$2;

Parameter values:

$1 => -42
$2 => "foo\n 1 AND 1=0 UNION SELECT * FROM secrets; --"

Resulting query after preparation:

SELECT * FROM example WHERE result=--42 OR name= 'foo
1 AND 1=0 UNION SELECT * FROM secrets; --';

Patches

The problem is resolved in v4.18.2.

Workarounds

Do not use the simple protocol or do not place a minus directly before a placeholder.

Severity

High Basis: The source's own band: HIGH

Dates

Published
2024-03-04 20:13 UTC
Modified
2026-09-10 03:50 UTC

Affected packages and fixes

github.com/jackc/pgx

Go · All systems

Affected

  • introduced 0, fixed 4.18.2 (semver)

Fixed versions

4.18.2

Fix

github.com/jackc/pgx/v4

Go · All systems

Affected

  • introduced 0, fixed 4.18.2 (semver)

Fixed versions

4.18.2

Fix

Fix commands are the export's own generic commands. Ojuju never runs them. Check them against your setup first.

Check your own computer: guard packages check

View this record on OSV.dev

Source

Source: GitHub Advisory Database (reviewed advisories) · CC BY 4.0

Sources & licences