Advisory

GHSA-mh8j-9jvh-gjf6

Also known as: CVE-2023-26158

Summary

mockjs vulnerable to Prototype Pollution via the Util.extend function

Details

All versions of the package mockjs are vulnerable to Prototype Pollution via the Util.extend function due to missing check if the attribute resolves to the object prototype. By adding or modifying attributes of an object prototype, it is possible to create attributes that exist on every object, or replace critical attributes with malicious ones. This can be problematic if the software depends on existence or non-existence of certain attributes, or uses pre-defined attributes of object prototype (such as hasOwnProperty, toString or valueOf).

User controlled inputs inside the extend() method of the Mock.Handler, Mock.Random, Mock.RE.Handler or Mock.Util, will allow an attacker to exploit this vulnerability.

Workaround

By using a denylist of dangerous attributes, this weakness can be eliminated.

Add the following line in the Util.extend function:

js
js if (["__proto__", "constructor", "prototype"].includes(name)) continue

js
// src/mock/handler.js
Util.extend = function extend() {
var target = arguments[0] || {},
i = 1,
length = arguments.length,
options, name, src, copy, clone

if (length === 1) {
target = this
i = 0
}

for (; i < length; i++) {
options = arguments[i]
if (!options) continue

for (name in options) {
if (["__proto__", "constructor", "prototype"].includes(name)) continue
src = target[name]
copy = options[name]

if (target === copy) continue
if (copy === undefined) continue

if (Util.isArray(copy) || Util.isObject(copy)) {
if (Util.isArray(copy)) clone = src && Util.isArray(src) ? src : []
if (Util.isObject(copy)) clone = src && Util.isObject(src) ? src : {}

target[name] = Util.extend(clone, copy)
} else {
target[name] = copy
}
}
}

return target
}

Severity

High Basis: The source's own band: HIGH

Dates

Published
2023-12-08 06:30 UTC
Modified
2023-12-08 16:11 UTC

Affected packages and fixes

mockjs

npm · All systems

Affected

  • introduced 0, last affected 1.1.0 (semver)

Fixed versions

None listed

Fix

No fixed version is listed.

Fix commands are the export's own generic commands. Ojuju never runs them. Check them against your setup first.

Check your own computer: guard packages check

View this record on OSV.dev

Source

Source: GitHub Advisory Database (reviewed advisories) · CC BY 4.0

Sources & licences