Advisory

GHSA-p5w8-wqhj-9hhf

Also known as: CVE-2021-32839, PYSEC-2021-333

Summary

StripComments filter contains a regular expression that is vulnerable to ReDOS (Regular Expression Denial of Service)

Details

Impact
The formatter function that strips comments from a SQL contains a regular expression that is vulnerable to ReDoS (Regular Expression Denial of Service). The regular expression may cause exponential backtracking on strings containing many repetitions of '\r\n' in SQL comments.

Patches
The issues has been fixed in sqlparse 0.4.2.

Workarounds
Only the formatting feature that removes comments from SQL statements is affected by this regular expression. As a workaround don't use the sqlformat.format function with keyword strip_comments=True or the --strip-comments command line flag when using the sqlformat command line tool.

References
This issue was discovered by GitHub team members @erik-krogh and @yoff. It was found using a CodeQL query which identifies inefficient regular expressions. You can see the results of the query on python-sqlparse by following this link.

For more information
If you have any questions or comments about this advisory:

Severity

High Basis: The source's own band: HIGH

Dates

Published
2021-09-10 17:56 UTC
Modified
2026-07-08 06:29 UTC

Affected packages and fixes

sqlparse

PyPI · All systems

Affected

  • introduced 0.4.0, fixed 0.4.2 (ecosystem)

Fixed versions

0.4.2

Fix

  • Fixed version 0.4.2
    pip install --upgrade sqlparse==0.4.2

Fix commands are the export's own generic commands. Ojuju never runs them. Check them against your setup first.

Check your own computer: guard packages check

View this record on OSV.dev

Source

Source: GitHub Advisory Database (reviewed advisories) · CC BY 4.0

Sources & licences