Details
Recommended Fix
Require exact redirect URI matching per the spec. Compare scheme, host, and path together:
redirectNorm := strings.ToLower(redirectURL.Scheme) + "://" +
strings.ToLower(redirectURL.Host) +
redirectURL.Path
for _, item := range allowed {
allowURL, parseErr := url.Parse(strings.TrimSpace(item))
if parseErr != nil || allowURL == nil || allowURL.Host == "" {
continue
}
allowNorm := strings.ToLower(allowURL.Scheme) + "://" +
strings.ToLower(allowURL.Host) +
allowURL.Path
if redirectNorm == allowNorm {
matched = true
break
}
}
Validate the redirect_uri at login time too, so a malformed value never enters the state JWT:
func (s *AuthService) GetOAuthLoginURL(provider, redirectURI string) (string, error) {
if redirectURI != "" {
if _, err := s.parseAndValidateClientRedirect(redirectURI); err != nil {
return "", err
}
}
// ... rest unchanged
}
Document the exact-match semantics in the admin panel. Every allowlisted return URL needs the full path the front-end lands on.
---
*Found by aisafe.io*