Advisory

GHSA-pvgv-gcp7-v38g

Details, part 2 of 2. The advisory

Details

Apply the same change to isTrustedNodeRequest in websocket_origin.go.

Fix 2 — Redesign cluster node configuration format:

The cluster node URL format must not embed secrets in query parameters. Use a separate configuration key:

[cluster]
Node     = http://10.0.0.1:9000?name=node1&enabled=true
NodeKey1 = <secret-for-node1>

Or store secrets in a separate secrets file with restricted permissions.

Fix 3 — Encrypt node tokens at rest:

The nodes.token column in the SQLite database stores secrets in plaintext. Encrypt using the CryptoSettings.Secret key before storage.

Fix 4 — Add secret rotation support:

Provide an API endpoint to rotate the Node.Secret and invalidate all existing sessions authenticated via the old secret.

---

8. Timeline

| Date | Event |
|---|---|
| 2026-04-21 | Vulnerability identified via source code review |
| — | Vendor notification (pending) |
| — | CVE assignment (pending) |

Citations

File: internal/middleware/middleware.go (L73-80)

// getNodeSecret from header or query
func getNodeSecret(c *gin.Context) (secret string) {
	if secret = c.GetHeader("X-Node-Secret"); secret != "" {
		return secret
	}

	return c.Query("node_secret")
}

File: internal/middleware/middleware.go (L96-103)

		// Check node secret authentication
		if nodeSecret := getNodeSecret(c); nodeSecret != "" && nodeSecret == settings.NodeSettings.Secret {
			initUser := user.GetInitUser(c)
			c.Set("Secret", nodeSecret)
			c.Set("user", initUser)
			c.Next()
			return
		}

File: internal/middleware/middleware.go (L152-158)

		if nodeSecret := getNodeSecret(c); nodeSecret != "" && nodeSecret == settings.NodeSettings.Secret {
			initUser := user.GetInitUser(c)
			c.Set("Secret", nodeSecret)
			c.Set("user", initUser)
			c.Next()
			return
		}

File: internal/middleware/websocket_origin.go (L39-46)

func isTrustedNodeRequest(r *http.Request) bool {
	secret := strings.TrimSpace(r.Header.Get("X-Node-Secret"))
	if secret == "" {
		secret = strings.TrimSpace(r.URL.Query().Get("node_secret"))
	}

	return secret != "" && secret == settings.NodeSettings.Secret
}

File: docs/guide/config-server.md (L109-111)

This secret is used to authenticate the communication between the Nginx UI servers.
Also, you can use this secret to access the Nginx UI API without a password.

File: app.example.ini (L45-48)

[cluster]
Node = http://10.0.0.1:9000?name=node1&node_secret=my-node-secret&enabled=true
Node = http://10.0.0.2:9000?name=node2&node_secret=my-node-secret&enabled=true
Node = http://10.0.0.3?name=node3&node_secret=my-node-secret&enabled=true

File: internal/cluster/cluster.go (L55-73)

func parseNodeUrl(nodeUrl string) (node *model.Node, err error) {
	u, err := url.Parse(nodeUrl)
	if err != nil {
		return
	}
	var sb strings.Builder
	sb.WriteString(u.Scheme)
	sb.WriteString("://")
	sb.WriteString(u.Host)
	sb.WriteString(u.Path)

	node = &model.Node{
		Name:    u.Query().Get("name"),
		URL:     sb.String(),
		Token:   u.Query().Get("node_secret"),
		Enabled: u.Query().Get("enabled") == "true",
	}

	return

File: internal/kernel/boot.go (L132-144)

func InitNodeSecret() {
	if settings.NodeSettings.Secret == "" {
		logger.Info("Secret is empty, generating...")
		uuidStr := uuid.New().String()
		err := settings.Update(func() {
			settings.NodeSettings.Secret = uuidStr
		})
		if err != nil {
			logger.Error("Error save settings", err)
		}
		logger.Info("Generated Secret: ", uuidStr)
	}
}

Sources & licences