Advisory

GHSA-pxm4-r5ph-q2m2

Also known as: CVE-2024-52806

Summary

SimpleSAMLphp SAML2 has an XXE in parsing SAML messages

Details

Summary

When loading an (untrusted) XML document, for example the SAMLResponse, it's possible to induce an XXE.

$options is defined as: https://github.com/simplesamlphp/saml2/blob/717c0adc4877ebd58428637e5626345e59fa0109/src/SAML2/DOMDocumentFactory.php#L41
including the DTDLoad option, which allows an attacker to read file contents from local file system OR internal network.

While there is the NONET option, an attacker can simply bypass if by using PHP filters:
php://filter/convert.base64-encode/resource=http://URL OR FILE

From there an attacker can induce network connections and steal the targeted file OOB (haven't fully tested this).

RCE may be possible with the php://expect or php://phar wrappers, but this hasn't been tested.

Note:
The mitigation here:
https://github.com/simplesamlphp/saml2/blob/717c0adc4877ebd58428637e5626345e59fa0109/src/SAML2/DOMDocumentFactory.php#L63-L69
Comes too late, as the XML has already been loaded into a document.
Mitigation:

Remove the LIBXML_DTDLOAD | LIBXML_DTDATTR options.
Additionally, as a defense in depth measure, check if there is the string: <!DOCTYPE inside the XML before parsing it. (This is not a complete fix because someone may be able to exploit some parser differentials, to load a DOCTYPE, maybe through spacing like: <! DOCTYPE)

Severity

Medium Basis: The source's own band: MODERATE

Dates

Published
2024-12-02 17:25 UTC
Modified
2024-12-13 20:51 UTC

Affected packages and fixes

simplesamlphp/saml2

Packagist · All systems

Affected

  • introduced 0, fixed 4.6.14 (ecosystem)

Fixed versions

4.6.14

Fix

The export has no generic command for this ecosystem.

simplesamlphp/saml2-legacy

Packagist · All systems

Affected

  • introduced 0, fixed 4.6.14 (ecosystem)

Fixed versions

4.6.14

Fix

The export has no generic command for this ecosystem.

Fix commands are the export's own generic commands. Ojuju never runs them. Check them against your setup first.

Check your own computer: guard packages check

View this record on OSV.dev

Source

Source: GitHub Advisory Database (reviewed advisories) · CC BY 4.0

Sources & licences