Advisory

GHSA-qh9x-gcfh-pcrw

Also known as: CVE-2022-31170

Summary

OpenZeppelin Contracts's ERC165Checker may revert instead of returning false

Details

Impact

ERC165Checker.supportsInterface is designed to always successfully return a boolean, and under no circumstance revert. However, an incorrect assumption about Solidity 0.8's abi.decode allows some cases to revert, given a target contract that doesn't implement EIP-165 as expected, specifically if it returns a value other than 0 or 1.

The contracts that may be affected are those that use ERC165Checker to check for support for an interface and then handle the lack of support in a way other than reverting.

Patches

The issue was patched in 4.7.1.

References

https://github.com/OpenZeppelin/openzeppelin-contracts/pull/3552

For more information

If you have any questions or comments about this advisory, or need assistance deploying the fix, email us at [[email protected]](mailto:[email protected]).

Severity

High Basis: The source's own band: HIGH

Dates

Published
2022-07-21 22:33 UTC
Modified
2023-11-08 04:09 UTC

Affected packages and fixes

@openzeppelin/contracts

npm · All systems

Affected

  • introduced 4.0.0, fixed 4.7.1 (semver)

Fixed versions

4.7.1

Fix

@openzeppelin/contracts-upgradeable

npm · All systems

Affected

  • introduced 4.0.0, fixed 4.7.1 (semver)

Fixed versions

4.7.1

Fix

Fix commands are the export's own generic commands. Ojuju never runs them. Check them against your setup first.

Check your own computer: guard packages check

View this record on OSV.dev

Source

Source: GitHub Advisory Database (reviewed advisories) · CC BY 4.0

Sources & licences