Advisory

GHSA-qp29-wcc2-vmpc

Also known as: None

Summary

Silverstripe HtmlEditor embed url sanitisation

Details

"Add from URL" doesn't clearly sanitise URL server side

HtmlEditorField_Toolbar has an action HtmlEditorField_Toolbar#viewfile, which gets called by the CMS when adding a media "from a URL" (i.e. via oembed).

This action gets the URL to add in the GET parameter FileURL. However it doesn't do any URL sanitising server side. The current logic will pass this through to Oembed, which will probably reject most dangerous URLs, but it's possible future changes would break this.

Severity

Medium Basis: The source's own band: MODERATE

Dates

Published
2024-05-23 18:14 UTC
Modified
2024-11-28 05:41 UTC

Affected packages and fixes

silverstripe/framework

Packagist · All systems

Affected

  • introduced 3.0.0, fixed 3.2.1 (ecosystem)

Fixed versions

3.2.1

Fix

The export has no generic command for this ecosystem.

Fix commands are the export's own generic commands. Ojuju never runs them. Check them against your setup first.

Check your own computer: guard packages check

View this record on OSV.dev

Source

Source: GitHub Advisory Database (reviewed advisories) · CC BY 4.0

Sources & licences