Advisory

GHSA-qvp4-rpmr-xwrr

Also known as: CVE-2021-32701, GHSA-vfvf-6gx5-mqv6, GO-2022-0406, GO-2022-0920

Summary

Possible bypass of token claim validation when OAuth2 Introspection caching is enabled

Details

Impact

When you make a request to an endpoint that requires the scope foo using an access token granted with that foo scope, introspection will be valid and that token will be cached. The problem comes when a second requests to an endpoint that requires the scope bar is made before the cache has expired. Whether the token is granted or not to the bar scope, introspection will be valid.

Patches

A patch will be released with v0.38.12-beta.1.

Workarounds

Per default, caching is disabled for the oauth2_introspection authenticator. When caching is disabled, this vulnerability does not exist.

Trace

The cache is checked in `func (a *AuthenticatorOAuth2Introspection) Authenticate(...)`. From `tokenFromCache()` it seems that it only validates the token expiration date, but ignores whether the token has or not the proper scopes.

Post-Mortem

The vulnerability was introduced in PR #424. During review, we failed to require appropriate test coverage by the submitter which is the primary reason that the vulnerability passed the review process.

To avoid this from happening again we enabled codecov with a strict policy on the Ory Oathkeeper repository: Without an increase in code coverage the PR can not be merged.

To address this issue and any regressions we have added a test suite ensuring that the cache behaviour is correct in the different scenarios:

  • Scope strategy is none, cache is enabled, and requested_scope is not empty -> cache will not be used;
  • Scope strategy is none, cache is enabled, and requested_scope is empty -> cache will be used;
  • Scope strategy is not none, cache is enabled, and requested_scope is not empty -> cache will be used;

as well as validating if iss, aud, exp, token_use, and scope are validated.

Additionally, we added CodeQL scanning to the CI.

Severity

High Basis: The source's own band: HIGH

Dates

Published
2021-06-23 18:00 UTC
Modified
2026-09-10 03:49 UTC

Affected packages and fixes

github.com/ory/oathkeeper

Go · All systems

Affected

  • introduced 0.38.0-beta.2, fixed 0.38.12-beta.1 (semver)

Fixed versions

0.38.12-beta.1

Fix

Fix commands are the export's own generic commands. Ojuju never runs them. Check them against your setup first.

Check your own computer: guard packages check

View this record on OSV.dev

Source

Source: GitHub Advisory Database (reviewed advisories) · CC BY 4.0

Sources & licences