Advisory

GHSA-rcjv-mgp8-qvmr

Also known as: CVE-2023-45142, GO-2023-2113

Summary

OpenTelemetry-Go Contrib vulnerable to denial of service in otelhttp due to unbound cardinality metrics

Details

Summary

This handler wrapper https://github.com/open-telemetry/opentelemetry-go-contrib/blob/5f7e6ad5a49b45df45f61a1deb29d7f1158032df/instrumentation/net/http/otelhttp/handler.go#L63-L65
out of the box adds labels

  • http.user_agent
  • http.method

that have unbound cardinality. It leads to the server's potential memory exhaustion when many malicious requests are sent to it.

Details

HTTP header User-Agent or HTTP method for requests can be easily set by an attacker to be random and long. The library internally uses httpconv.ServerRequest that records every value for HTTP method and User-Agent.

PoC

Send many requests with long randomly generated HTTP methods or/and User agents (e.g. a million) and observe how memory consumption increases during it.

Impact

In order to be affected, the program has to configure a metrics pipeline, use otelhttp.NewHandler wrapper, and does not filter any unknown HTTP methods or User agents on the level of CDN, LB, previous middleware, etc.

Others

It is similar to already reported vulnerabilities

Workaround for affected versions

As a workaround to stop being affected otelhttp.WithFilter() can be used, but it requires manual careful configuration to not log certain requests entirely.

For convenience and safe usage of this library, it should by default mark with the label unknown non-standard HTTP methods and User agents to show that such requests were made but do not increase cardinality. In case someone wants to stay with the current behavior, library API should allow to enable it.

The other possibility is to disable HTTP metrics instrumentation by passing `otelhttp.WithMeterProvider` option with `noop.NewMeterProvider`.

Solution provided by upgrading

In PR https://github.com/open-telemetry/opentelemetry-go-contrib/pull/4277, released with package version 0.44.0, the values collected for attribute http.request.method were changed to be restricted to a set of well-known values and other high cardinality attributes were removed.

References

  • https://github.com/open-telemetry/opentelemetry-go-contrib/pull/4277
  • https://github.com/open-telemetry/opentelemetry-go-contrib/releases/tag/v1.19.0

Severity

High Basis: The source's own band: HIGH

Dates

Published
2023-10-16 14:01 UTC
Modified
2026-09-10 03:49 UTC

Affected packages and fixes

go.opentelemetry.io/contrib/instrumentation/net/http/otelhttp

Go · All systems

Affected

  • introduced 0, fixed 0.44.0 (semver)

Fixed versions

0.44.0

Fix

  • Fixed version 0.44.0
    go get go.opentelemetry.io/contrib/instrumentation/net/http/[email protected]

go.opentelemetry.io/contrib/instrumentation/github.com/emicklei/go-restful/otelrestful

Go · All systems

Affected

  • introduced 0, fixed 0.44.0 (semver)

Fixed versions

0.44.0

Fix

  • Fixed version 0.44.0
    go get go.opentelemetry.io/contrib/instrumentation/github.com/emicklei/go-restful/[email protected]

go.opentelemetry.io/contrib/instrumentation/github.com/gin-gonic/gin/otelgin

Go · All systems

Affected

  • introduced 0, fixed 0.44.0 (semver)

Fixed versions

0.44.0

Fix

  • Fixed version 0.44.0
    go get go.opentelemetry.io/contrib/instrumentation/github.com/gin-gonic/gin/[email protected]

go.opentelemetry.io/contrib/instrumentation/github.com/gorilla/mux/otelmux

Go · All systems

Affected

  • introduced 0, fixed 0.44.0 (semver)

Fixed versions

0.44.0

Fix

  • Fixed version 0.44.0
    go get go.opentelemetry.io/contrib/instrumentation/github.com/gorilla/mux/[email protected]

go.opentelemetry.io/contrib/instrumentation/github.com/labstack/echo/otelecho

Go · All systems

Affected

  • introduced 0, fixed 0.44.0 (semver)

Fixed versions

0.44.0

Fix

  • Fixed version 0.44.0
    go get go.opentelemetry.io/contrib/instrumentation/github.com/labstack/echo/[email protected]

go.opentelemetry.io/contrib/instrumentation/gopkg.in/macaron.v1/otelmacaron

Go · All systems

Affected

  • introduced 0, fixed 0.44.0 (semver)

Fixed versions

0.44.0

Fix

  • Fixed version 0.44.0
    go get go.opentelemetry.io/contrib/instrumentation/gopkg.in/macaron.v1/[email protected]

go.opentelemetry.io/contrib/instrumentation/net/http/httptrace/otelhttptrace

Go · All systems

Affected

  • introduced 0, fixed 0.44.0 (semver)

Fixed versions

0.44.0

Fix

  • Fixed version 0.44.0
    go get go.opentelemetry.io/contrib/instrumentation/net/http/httptrace/[email protected]

Fix commands are the export's own generic commands. Ojuju never runs them. Check them against your setup first.

Check your own computer: guard packages check

View this record on OSV.dev

Source

Source: GitHub Advisory Database (reviewed advisories) · CC BY 4.0

Sources & licences