Details
Option 2: Add traversal protection to _extractEntryTo as well
The _extractEntryTo function (line 262) also lacks a traversal check. For defense-in-depth, add validation there too:
async function _extractEntryTo(zipFile, entry, destDir) {
const dstPath = path.resolve(destDir, entry.fileName);
const canonicalDest = path.resolve(dstPath);
const canonicalDestDir = path.resolve(destDir);
if (!canonicalDest.startsWith(canonicalDestDir + path.sep) && canonicalDest !== canonicalDestDir) {
throw new Error(
`Out of bound path "${canonicalDest}" found while processing file ${entry.fileName}`
);
}
// ... rest of function
}
Credit
This vulnerability was discovered and reported by bugbunny.ai.