Advisory

GHSA-rmxw-pq4x-3fvh

Also known as: CVE-2026-54719, GO-2026-6133

Summary

goshs: File-based .goshs ACL authorization bypass via the ?bulk zip-download route (unauthenticated read; residual of GHSA-wvhv-qcqf-f3cx)

Details

GHSA-wvhv-qcqf-f3cx fixed the per-folder .goshs ACL bypass on the state-changing routes (PUT/POST upload/?mkdir/?delete) and added recursive ACL resolution, and its description states the read/list path correctly enforces .goshs. That premise does not hold for the ?bulk zip-download route. bulkDownload (httpserver/updown.go) takes one or more ?file= parameters, runs each through sanitizePath(fs.Webroot, file), and streams the contents back as a ZIP without ever calling findEffectiveACL/applyCustomAuth. It is dispatched from earlyBreakParameters (?bulk) before the normal doDir/doFile/sendFile flow that performs the ACL check. An unauthenticated attacker can therefore read any file under the webroot protected solely by a .goshs ACL, bypassing both the folder auth (401 on the normal path) and the per-file block list (404 on the normal path). Same authorization-inconsistency root cause as the original advisory, surviving on a read route the fix did not cover.

Proof of concept (live, against the fixed v2.1.0 build which includes fix commit f212c4f4, served with no global -b auth, only a per-folder .goshs):
GET /protected/secret.txt -> 401 (ACL enforced on normal path)
GET /protected/secret.txt -u admin:admin -> 200
GET /?bulk&file=/protected/secret.txt -> 200, zip contains the protected file contents (BYPASS)
GET /?bulk&file=/protected/blocked.txt -> 200, zip contains the block-listed file (block bypass)
GET /protected/secret.txt?share -> 403 'Sharing disabled when auth is disabled' (correctly gated, NOT a bypass)

Impact: any unauthenticated network attacker can read files an operator protected with the documented per-folder .goshs ACL/basic-auth feature, by requesting them through ?bulk. Confidentiality only (the write/delete equivalents were closed by GHSA-wvhv-qcqf-f3cx). Applies to deployments relying on .goshs as the access boundary (a server-wide -b basic auth, if configured, also gates ?bulk via its middleware).

Remediation: enforce the effective .goshs ACL inside bulkDownload for every requested file exactly as sendFile/processDir do (resolve findEffectiveACL(filepath.Dir(absPath)) + applyCustomAuth + honor acl.Block), or route ?bulk through the same authorization gate as the normal read path. Audit ?cbDown and other alternate read routes for the same gap.

Credit: anir0y (independent security research).

Severity

High Basis: The source's own band: HIGH

Dates

Published
2026-07-28 21:59 UTC
Modified
2026-08-18 15:11 UTC

Affected packages and fixes

github.com/patrickhener/goshs

Go · All systems

Affected

  • introduced 0, last affected 1.1.4 (semver)

Fixed versions

None listed

Fix

No fixed version is listed.

github.com/patrickhener/goshs/v2

Go · All systems

Affected

  • introduced 0, fixed 2.1.1 (semver)

Fixed versions

2.1.1

Fix

goshs.de/goshs

Go · All systems

Affected

  • introduced 0, last affected 1.1.4 (semver)

Fixed versions

None listed

Fix

No fixed version is listed.

goshs.de/goshs/v2

Go · All systems

Affected

  • introduced 0, fixed 2.1.1 (semver)

Fixed versions

2.1.1

Fix

Fix commands are the export's own generic commands. Ojuju never runs them. Check them against your setup first.

Check your own computer: guard packages check

View this record on OSV.dev

Source

Source: GitHub Advisory Database (reviewed advisories) · CC BY 4.0

Sources & licences