netbox-data-flows
Affected
- introduced
0, fixed1.5.1(ecosystem)
Fixed versions
1.5.1
Fix
- Fixed version
1.5.1pip install --upgrade netbox-data-flows==1.5.1
Advisory
Also known as: None
netbox-data-flows has stored XSS in ObjectAlias names rendered inside DataFlow tables
Summary
An authenticated user who can create or edit ObjectAlias objects can store arbitrary HTML/JavaScript in an alias name. That payload is later rendered unescaped in DataFlow table views, causing a stored XSS when another user views the affected page.
Details
The issue is caused by unsafe HTML generation in the plugin’s custom table column renderer.
Relevant code on main (bf96eac, same commit as origin/main at the time of review):
netbox_data_flows/models/objectaliases.pyObjectAlias.name is user-controlled (CharField)ObjectAlias.__str__() returns self.name directlynetbox_data_flows/tables/dataflows.pyDataFlowTable.sources and DataFlowTable.destinations use ObjectAliasListColumnnetbox_data_flows/tables/columns.pyObjectAliasListColumn.render() calls object_list_to_string(value.all(), linkify=True)netbox_data_flows/utils/helpers.pyobject_list_to_string() builds raw anchor tags with: python mark_safe(separator.join(f'<a href="{o.get_absolute_url()}">{o}</a>' for o in objects)) The alias text ({o}) is inserted into HTML without escaping, then the whole string is marked safe. Because ObjectAlias.__str__() returns the user-supplied name, HTML/JS in the alias name is executed in the victim’s browser.
This affects any page rendering DataFlowTable, including at least:
DataFlowTablePoC
Environment:
netbox-data-flows installedSteps:
ObjectAlias and DataFlow.ObjectAlias with the following name: <img src=x onerror=alert(document.domain)>
DataFlow so this alias is present in either sources or destinations.A simple path to trigger is the Data Flow list page. Any other page that renders DataFlowTable should also be tested.
Impact
This is a stored cross-site scripting vulnerability.
Impacted users:
DataFlow tablePossible impact:
High Basis: The source's own band: HIGH
0, fixed 1.5.1 (ecosystem)1.5.1
1.5.1pip install --upgrade netbox-data-flows==1.5.1Fix commands are the export's own generic commands. Ojuju never runs them. Check them against your setup first.
Check your own computer: guard packages check
Source: GitHub Advisory Database (reviewed advisories) · CC BY 4.0