Advisory

GHSA-vfmv-jfc5-pjjw

Also known as: CVE-2024-29034

Summary

CarrierWave content-Type allowlist bypass vulnerability which possibly leads to XSS remained

Details

Impact
The vulnerability CVE-2023-49090 wasn't fully addressed.

This vulnerability is caused by the fact that when uploading to object storage, including Amazon S3, it is possible to set a Content-Type value that is interpreted by browsers to be different from what's allowed by content_type_allowlist, by providing multiple values separated by commas.

This bypassed value can be used to cause XSS.

Patches
Upgrade to 3.0.7 or 2.2.6.

Workarounds
Use the following monkey patch to let CarrierWave parse the Content-type by using Marcel::MimeType.for.

# For CarrierWave 3.x
CarrierWave::SanitizedFile.class_eval do
  def declared_content_type
    @declared_content_type ||
      if @file.respond_to?(:content_type) && @file.content_type
        Marcel::MimeType.for(declared_type: @file.content_type.to_s.chomp)
      end
  end
end
# For CarrierWave 2.x
CarrierWave::SanitizedFile.class_eval do
  def existing_content_type
    if @file.respond_to?(:content_type) && @file.content_type
      Marcel::MimeType.for(declared_type: @file.content_type.to_s.chomp)
    end
  end
end

References
OWASP - File Upload Cheat Sheet

Severity

Medium Basis: The source's own band: MODERATE

Dates

Published
2024-03-25 19:40 UTC
Modified
2024-03-27 13:00 UTC

Affected packages and fixes

carrierwave

RubyGems · All systems

Affected

  • introduced 3.0.0, fixed 3.0.7 (ecosystem)

Fixed versions

3.0.7

Fix

The export has no generic command for this ecosystem.

carrierwave

RubyGems · All systems

Affected

  • introduced 0, fixed 2.2.6 (ecosystem)

Fixed versions

2.2.6

Fix

The export has no generic command for this ecosystem.

Fix commands are the export's own generic commands. Ojuju never runs them. Check them against your setup first.

Check your own computer: guard packages check

View this record on OSV.dev

Source

Source: GitHub Advisory Database (reviewed advisories) · CC BY 4.0

Sources & licences