tensorflow
Affected
- introduced
0, fixed2.3.4(ecosystem)
Fixed versions
2.3.4
Fix
- Fixed version
2.3.4pip install --upgrade tensorflow==2.3.4
Advisory
Also known as: BIT-tensorflow-2021-37669, CVE-2021-37669, PYSEC-2021-291, PYSEC-2021-582, PYSEC-2021-780
Crash in NMS ops caused by integer conversion to unsigned
Impact
An attacker can cause denial of service in applications serving models using tf.raw_ops.NonMaxSuppressionV5 by triggering a division by 0:
import tensorflow as tf
tf.raw_ops.NonMaxSuppressionV5(
boxes=[[0.1,0.1,0.1,0.1],[0.2,0.2,0.2,0.2],[0.3,0.3,0.3,0.3]],
scores=[1.0,2.0,3.0],
max_output_size=-1,
iou_threshold=0.5,
score_threshold=0.5,
soft_nms_sigma=1.0,
pad_to_max_output_size=True)
The implementation uses a user controlled argument to resize a std::vector:
const int output_size = max_output_size.scalar<int>()();
// ...
std::vector<int> selected;
// ...
if (pad_to_max_output_size) {
selected.resize(output_size, 0);
// ...
}
However, as std::vector::resize takes the size argument as a size_t and output_size is an int, there is an implicit conversion to usigned. If the attacker supplies a negative value, this conversion results in a crash.
A similar issue occurs in CombinedNonMaxSuppression:
import tensorflow as tf
tf.raw_ops.NonMaxSuppressionV5(
boxes=[[[[0.1,0.1,0.1,0.1],[0.2,0.2,0.2,0.2],[0.3,0.3,0.3,0.3]],[[0.1,0.1,0.1,0.1],[0.2,0.2,0.2,0.2],[0.3,0.3,0.3,0.3]],[[0.1,0.1,0.1,0.1],[0.2,0.2,0.2,0.2],[0.3,0.3,0.3,0.3]]]],
scores=[[[1.0,2.0,3.0],[1.0,2.0,3.0],[1.0,2.0,3.0]]],
max_output_size_per_class=-1,
max_total_size=10,
iou_threshold=score_threshold=0.5,
pad_per_class=True,
clip_boxes=True)
Patches
We have patched the issue in GitHub commit 3a7362750d5c372420aa8f0caf7bf5b5c3d0f52d and commit b5cdbf12ffcaaffecf98f22a6be5a64bb96e4f58.
The fix will be included in TensorFlow 2.6.0. We will also cherrypick this commit on TensorFlow 2.5.1, TensorFlow 2.4.3, and TensorFlow 2.3.4, as these are also affected and still in supported range.
For more information
Please consult our security guide for more information regarding the security model and how to contact us with issues and questions.
Attribution
This vulnerability has been reported by members of the Aivul Team from Qihoo 360.
Medium Basis: The source's own band: MODERATE
0, fixed 2.3.4 (ecosystem)2.3.4
2.3.4pip install --upgrade tensorflow==2.3.42.4.0, fixed 2.4.3 (ecosystem)2.4.3
2.4.3pip install --upgrade tensorflow==2.4.32.5.0, fixed 2.5.1 (ecosystem)2.5.1
2.5.1pip install --upgrade tensorflow==2.5.10, fixed 2.3.4 (ecosystem)2.3.4
2.3.4pip install --upgrade tensorflow-cpu==2.3.42.4.0, fixed 2.4.3 (ecosystem)2.4.3
2.4.3pip install --upgrade tensorflow-cpu==2.4.32.5.0, fixed 2.5.1 (ecosystem)2.5.1
2.5.1pip install --upgrade tensorflow-cpu==2.5.10, fixed 2.3.4 (ecosystem)2.3.4
2.3.4pip install --upgrade tensorflow-gpu==2.3.42.4.0, fixed 2.4.3 (ecosystem)2.4.3
2.4.3pip install --upgrade tensorflow-gpu==2.4.32.5.0, fixed 2.5.1 (ecosystem)2.5.1
2.5.1pip install --upgrade tensorflow-gpu==2.5.1Fix commands are the export's own generic commands. Ojuju never runs them. Check them against your setup first.
Check your own computer: guard packages check
Source: GitHub Advisory Database (reviewed advisories) · CC BY 4.0