Details
When confirm returns false, try_sign returns false and the agent answers SSH_AGENT_FAILURE, as it did before the regression.
Compatibility note for the release notes: confirm is called again for confirm-constrained keys, so implementations that stub it out will now hit that stub.
- For example, Litterbox implements
confirmastodo!()(agent.rs L81-L87). - Each connection runs in its own task, so such a panic ends only that connection.
Related but separate: with the default confirm, the agent still accepts the confirm constraint without enforcing it. Given RFC 9987 §5.2.7, refusing such keys when the application does not implement confirm may be worth considering.