Advisory

GHSA-vxmm-cwh2-q762

Also known as: CVE-2023-32675, PYSEC-2023-80

Summary

Vyper's nonpayable default functions are sometimes payable

Details

Impact
in contracts with at least one regular nonpayable function, due to the callvalue check being inside of the selector section, it is possible to send funds to the default function by using less than 4 bytes of calldata, even if the default function is marked nonpayable. this applies to contracts compiled with vyper<=0.3.7.

# @version 0.3.7

# implicitly nonpayable
@external
def foo() -> uint256:
    return 1

# implicitly nonpayable
@external
def __default__():
    # could receive ether here
    pass

Patches
this was fixed by the removal of the global calldatasize check in https://github.com/vyperlang/vyper/commit/02339dfda0f3caabad142060d511d10bfe93c520.

Workarounds
don't use nonpayable default functions

Severity

Medium Basis: The source's own band: MODERATE

Dates

Published
2023-05-22 20:35 UTC
Modified
2026-02-22 22:56 UTC

Affected packages and fixes

vyper

PyPI · All systems

Affected

  • introduced 0, fixed 0.3.8 (ecosystem)

Fixed versions

0.3.8

Fix

  • Fixed version 0.3.8
    pip install --upgrade vyper==0.3.8

Fix commands are the export's own generic commands. Ojuju never runs them. Check them against your setup first.

Check your own computer: guard packages check

View this record on OSV.dev

Source

Source: GitHub Advisory Database (reviewed advisories) · CC BY 4.0

Sources & licences