Advisory

GHSA-wm63-7627-ch33

Also known as: None

Summary

@vendure/core's insecure currencyCode handling allows wrong payment amounts

Details

Impact

Currently, in many Vendure deployments it's possible to select any currencyCode (really any, doesn't need to be assigned to the channel) and pay through Mollie and Stripe in that particular currencyCode.
The prices are not transformed. The result is the Order is in Payment Settled in the foreign currency.
See SS, CZK is not in the channel.
I've tested with Mollie and Stripe it both works.

Further notes

After looking into this further and with help from the comments below, the root cause of this vulnerability is the ability to specify an arbitrary currencyCode as a query parameter to an API call, and then Vendure will use this and pass it to the rest of the system as RequestContext.currencyCode.

The solution is to add validation to the passed currencyCode to ensure that it matches one of the available availableCurrencyCodes of the active Channel.

Furthermore, an additional check has been added for when the currencyCode changes during the AddingItems stage - in this case we need to re-calculate the prices in the new currency.

Patches
v2.1.3

Workarounds
You can define a custom OrderProcess onTransitionStart function which can verify the order's currencyCode is as expected before allowing the transition to the ArrangingPayment state.

Severity

Medium Basis: The source's own band: MODERATE

Dates

Published
2023-11-17 21:50 UTC
Modified
2023-11-17 21:50 UTC

Affected packages and fixes

@vendure/core

npm · All systems

Affected

  • introduced 0, fixed 2.1.3 (semver)

Fixed versions

2.1.3

Fix

Fix commands are the export's own generic commands. Ojuju never runs them. Check them against your setup first.

Check your own computer: guard packages check

View this record on OSV.dev

Source

Source: GitHub Advisory Database (reviewed advisories) · CC BY 4.0

Sources & licences