curve25519-dalek
Affected
- introduced
0, fixed4.1.3(semver)
Fixed versions
4.1.3
Fix
- Fixed version
4.1.3cargo update -p curve25519-dalek --precise 4.1.3
Advisory
Also known as: CVE-2024-58262, RUSTSEC-2024-0344
curve25519-dalek has timing variability in curve25519-dalek's Scalar29::sub/Scalar52::sub
Timing variability of any kind is problematic when working with potentially secret values such as elliptic curve scalars, and such issues can potentially leak private keys and other secrets. Such a problem was recently discovered in curve25519-dalek.
The Scalar29::sub (32-bit) and Scalar52::sub (64-bit) functions contained usage of a mask value inside a loop where LLVM saw an opportunity to insert a branch instruction (jns on x86) to conditionally bypass this code section when the mask value is set to zero as can be seen in godbolt:
A similar problem was recently discovered in the Kyber reference implementation:
https://groups.google.com/a/list.nist.gov/g/pqc-forum/c/hqbtIGFKIpU/m/cnE3pbueBgAJ
As discussed on that thread, one portable solution, which is also used in this PR, is to introduce a volatile read as an optimization barrier, which prevents the compiler from optimizing it away.
The fix can be validated in godbolt here:
The problem was discovered and the solution independently verified by Alexander Wagner <[email protected]> and Lea Themint <[email protected]> using their DATA tool:
https://github.com/Fraunhofer-AISEC/DATA
Low Basis: The source's own band: LOW
0, fixed 4.1.3 (semver)4.1.3
4.1.3cargo update -p curve25519-dalek --precise 4.1.3Fix commands are the export's own generic commands. Ojuju never runs them. Check them against your setup first.
Check your own computer: guard packages check
Source: GitHub Advisory Database (reviewed advisories) · CC BY 4.0