Advisory

GHSA-xfrc-7mj2-5xh9

Also known as: None

Summary

Undefined Behavior in zencashjs

Details

Versions of zencashjs prior to 1.2.0 may cause loss of funds when used with cryptocurrency wallets. The package relies on a string comparison of the first two characters of a Horizen address to determine the destination address type of a transaction (P2PKH or P2SH). Due to the base58 address prefixes chosen in Horizen there exists the possibility of a clash of address prefixes for testnet P2PKH and mainnet P2SH addresses, testnet P2PKH addresses start with “zt” while a subset of mainnet P2SH addresses can also start with “zt”. The package interprets transactions sent to a “zt” P2SH address on mainnet as P2PKH transactions erroneously. Any funds sent to a mainnet P2SH multisignature address starting with “zt” will be sent to the wrong address and be lost.

Recommendation

Upgrade to version 1.2.0 or later.

Severity

Critical Basis: The source's own band: CRITICAL

Dates

Published
2020-09-03 17:14 UTC
Modified
2020-08-31 18:44 UTC

Affected packages and fixes

zencashjs

npm · All systems

Affected

  • introduced 0, fixed 1.2.0 (semver)

Fixed versions

1.2.0

Fix

Fix commands are the export's own generic commands. Ojuju never runs them. Check them against your setup first.

Check your own computer: guard packages check

View this record on OSV.dev

Source

Source: GitHub Advisory Database (reviewed advisories) · CC BY 4.0

Sources & licences