Advisory

GHSA-xp3q-r38w-vgqm

Details, part 2 of 2. The advisory

Details

The document and notebook identifiers disclosed here are also the input required by identifier-to-path and path-to-content resolution, so the value is not limited to the metadata itself.

No document bodies are returned, and nothing is written. Confidentiality only.

Suggested fix

Invert the filter into an actual allowlist. Return only the keys a publish reader needs to render published content, which is a short list along the lines of local-images, local-emojis, local-pdftheme, local-fontstyles and the theme and zoom preferences, and drop everything else by default. New keys added in future then default to withheld rather than exposed.

Additionally, pass *gin.Context into FilterLocalStorageByPublishAccess so that any retained per-document entry can be gated with the full CheckBlockIdAccessableByPublishAccess including the password tier, matching the sibling filters in the same file.

Sources & licences