Advisory

GHSA-xq52-rv6w-397c

Also known as: CVE-2020-5217

Summary

Directive injection when using dynamic overrides with user input

Details

Impact

If user-supplied input was passed into append/override_content_security_policy_directives, a semicolon could be injected leading to directive injection.

This could be used to e.g. override a script-src directive. Duplicate directives are ignored and the first one wins. The directives in secure_headers are sorted alphabetically so they pretty much all come before script-src. A previously undefined directive would receive a value even if SecureHeaders::OPT_OUT was supplied.

The fixed versions will silently convert the semicolons to spaces and emit a deprecation warning when this happens. This will result in innocuous browser console messages if being exploited/accidentally used. In future releases, we will raise application errors resulting in 500s.

> Duplicate script-src directives detected. All but the first instance will be ignored.

See https://www.w3.org/TR/CSP3/#parse-serialized-policy

> Note: In this case, the user agent SHOULD notify developers that a duplicate directive was ignored. A console warning might be appropriate, for example.

Patches

Depending on what major version you are using, the fixed versions are 6.2.0, 5.1.0, 3.8.0.

Workarounds

If you are passing user input into the above methods, you could filter out the input:

override_content_security_policy_directives(:frame_src, [user_input.gsub(";", " ")])

References

Reported in https://github.com/twitter/secure_headers/issues/418
https://www.w3.org/TR/CSP3/#parse-serialized-policy

For more information

If you have any questions or comments about this advisory:

  • Open an issue in this repo
  • DM @ndm on twitter

Severity

Medium Basis: The source's own band: MODERATE

Dates

Published
2020-01-23 02:28 UTC
Modified
2026-09-10 03:48 UTC

Affected packages and fixes

secure_headers

RubyGems · All systems

Affected

  • introduced 6.0.0, fixed 6.2.0 (ecosystem)

Fixed versions

6.2.0

Fix

The export has no generic command for this ecosystem.

secure_headers

RubyGems · All systems

Affected

  • introduced 5.0.0, fixed 5.1.0 (ecosystem)

Fixed versions

5.1.0

Fix

The export has no generic command for this ecosystem.

secure_headers

RubyGems · All systems

Affected

  • introduced 0, fixed 3.8.0 (ecosystem)

Fixed versions

3.8.0

Fix

The export has no generic command for this ecosystem.

Fix commands are the export's own generic commands. Ojuju never runs them. Check them against your setup first.

Check your own computer: guard packages check

View this record on OSV.dev

Source

Source: GitHub Advisory Database (reviewed advisories) · CC BY 4.0

Sources & licences