invenio-drafts-resources
Affected
- introduced
0, fixed0.13.7(ecosystem)
Fixed versions
0.13.7
Fix
- Fixed version
0.13.7pip install --upgrade invenio-drafts-resources==0.13.7
Advisory
Also known as: CVE-2021-43781, PYSEC-2021-836, PYSEC-2021-837, PYSEC-2021-838
Permissions not properly checked in Invenio-Drafts-Resources
Impact
Invenio-Drafts-Resources does not properly check permissions when a record is published. The vulnerability is exploitable in a default installation of InvenioRDM. An authenticated user is able via REST API calls to publish draft records of other users if they know the record identifier and the draft validates (e.g. all require fields filled out). An attacker is not able to modify the data in the record, and thus e.g. *cannot* change a record from restricted to public.
Details
The service's publish() method contains the following permission check:
def publish(..):
self.require_permission(identity, "publish")
However, the record should have been passed into the permission check so that the need generators have access to e.g. the record owner.
def publish(..):
self.require_permission(identity, "publish", record=record)
The bug is activated in Invenio-RDM-Records which has a need generator called RecordOwners(), which when no record is passed in defaults to allow any authenticated user:
class RecordOwners(Generator):
def needs(self, record=None, **kwargs):
if record is None:
return [authenticated_user]
# ...
Patches
The problem is patched in Invenio-Drafts-Resources v0.13.7 and 0.14.6+, which is part of InvenioRDM v6.0.1 and InvenioRDM v7.0 respectively.
You can verify the version installed of Invenio-Drafts-Resources via PIP:
cd ~/src/my-site
pipenv run pip freeze | grep invenio-drafts-resources
References
For more information
If you have any questions or comments about this advisory:
Medium Basis: The source's own band: MODERATE
0, fixed 0.13.7 (ecosystem)0.13.7
0.13.7pip install --upgrade invenio-drafts-resources==0.13.70, fixed 6.0.5 (ecosystem)6.0.5
6.0.5pip install --upgrade invenio-app-rdm==6.0.50, fixed 0.32.6 (ecosystem)0.32.6
0.32.6pip install --upgrade invenio-rdm-records==0.32.60.14.0, fixed 0.14.6 (ecosystem)0.14.6
0.14.6pip install --upgrade invenio-drafts-resources==0.14.60.33.0, fixed 0.33.10 (ecosystem)0.33.10
0.33.10pip install --upgrade invenio-rdm-records==0.33.107.0.0.dev0, fixed 7.0.0.dev5 (ecosystem)7.0.0.dev5
7.0.0.dev5pip install --upgrade invenio-app-rdm==7.0.0.dev5Fix commands are the export's own generic commands. Ojuju never runs them. Check them against your setup first.
Check your own computer: guard packages check
Source: GitHub Advisory Database (reviewed advisories) · CC BY 4.0