Advisory

GHSA-xrc4-737v-9q75

Also known as: CVE-2022-31198

Summary

OpenZeppelin Contracts's GovernorVotesQuorumFraction updates to quorum may affect past defeated proposals

Details

Impact

This issue concerns instances of Governor that use the module GovernorVotesQuorumFraction, a mechanism that determines quorum requirements as a percentage of the voting token's total supply. In affected instances, when a proposal is passed to lower the quorum requirement, past proposals may become executable if they had been defeated only due to lack of quorum, and the number of votes it received meets the new quorum requirement.

Analysis of instances on chain found only one proposal that met this condition, and we are actively monitoring for new occurrences of this particular issue.

Patches

This issue has been patched in v4.7.2.

Workarounds

Avoid lowering quorum requirements if a past proposal was defeated for lack of quorum.

References

https://github.com/OpenZeppelin/openzeppelin-contracts/pull/3561

For more information

If you have any questions or comments about this advisory, or need assistance deploying the fix, email us at [[email protected]](mailto:[email protected]).

Severity

High Basis: The source's own band: HIGH

Dates

Published
2022-08-18 18:48 UTC
Modified
2023-11-08 04:09 UTC

Affected packages and fixes

@openzeppelin/contracts

npm · All systems

Affected

  • introduced 4.3.0, fixed 4.7.2 (semver)

Fixed versions

4.7.2

Fix

@openzeppelin/contracts-upgradeable

npm · All systems

Affected

  • introduced 4.3.0, fixed 4.7.2 (semver)

Fixed versions

4.7.2

Fix

Fix commands are the export's own generic commands. Ojuju never runs them. Check them against your setup first.

Check your own computer: guard packages check

View this record on OSV.dev

Source

Source: GitHub Advisory Database (reviewed advisories) · CC BY 4.0

Sources & licences