Advisory

RUSTSEC-2020-0061

Also known as: CVE-2020-35907, GHSA-p9m5-3hj7-cp5r

Summary

futures_task::noop_waker_ref can segfault due to dereferencing a NULL pointer

Details

Affected versions of the crate used a UnsafeCell in thread-local storage to return a noop waker reference,
assuming that the reference would never be returned from another thread.

This resulted in a segmentation fault crash if Waker::wake_by_ref() was called on a waker returned from another thread due to
it attempting to dereference a pointer that wasn't accessible from the main thread.

Reproduction Example (from issue):

use futures_task::noop_waker_ref;
fn main() {
    let waker = std::thread::spawn(|| noop_waker_ref()).join().unwrap();
    waker.wake_by_ref();
}

The flaw was corrected by using a OnceCell::Lazy<> wrapper around the noop waker instead of thread-local storage.

Severity

Medium Basis: CVSS v3 score 5.5, vector CVSS:3.1/AV:L/AC:L/PR:L/UI:N/S:U/C:N/I:N/A:H

Dates

Published
2020-05-03 12:00 UTC
Modified
2023-11-08 04:03 UTC

Affected packages and fixes

futures-task

crates.io · All systems

Affected

  • introduced 0.0.0-0, fixed 0.3.5 (semver)

Fixed versions

0.3.5

Fix

  • Fixed version 0.3.5
    cargo update -p futures-task --precise 0.3.5

Fix commands are the export's own generic commands. Ojuju never runs them. Check them against your setup first.

Check your own computer: guard packages check

View this record on OSV.dev

Source

Source: RustSec Advisory Database · CC0-1.0

Sources & licences