Advisory

RUSTSEC-2022-0010

Also known as: GHSA-rxhx-9fj6-6h2m

Summary

enum_map macro can cause UB when Enum trait is incorrectly implemented

Details

Affected versions of this crate did not properly check the length of an enum when using enum_map! macro, trusting user-provided length.

When the LENGTH in the Enum trait does not match the array length in the EnumArray trait, this can result in the initialization of the enum map with uninitialized types, which in turn can allow an attacker to execute arbitrary code.

This problem can only occur with a manual implementation of the Enum trait, it will never occur for enums that use #[derive(Enum)].

Example code that triggers this vulnerability looks like this:

enum E {
    A,
    B,
    C,
}

impl Enum for E {
    const LENGTH: usize = 2;

    fn from_usize(value: usize) -> E {
        match value {
            0 => E::A,
            1 => E::B,
            2 => E::C,
            _ => unimplemented!(),
        }
    }

    fn into_usize(self) -> usize {
        self as usize
    }
}

impl<V> EnumArray<V> for E {
    type Array = [V; 3];
}

let _map: EnumMap<E, String> = enum_map! { _ => "Hello, world!".into() };

The flaw was corrected in commit b824e23 by putting LENGTH property on sealed trait for macro to read.

Severity

Not rated by the source.

Dates

Published
2022-02-17 12:00 UTC
Modified
2023-11-08 04:22 UTC

Affected packages and fixes

enum-map

crates.io · All systems

Affected

  • introduced 2.0.0-2, fixed 2.0.2 (semver)

Fixed versions

2.0.2

Fix

  • Fixed version 2.0.2
    cargo update -p enum-map --precise 2.0.2

Fix commands are the export's own generic commands. Ojuju never runs them. Check them against your setup first.

Check your own computer: guard packages check

View this record on OSV.dev

Source

Source: RustSec Advisory Database · CC0-1.0

Sources & licences