Advisory

RUSTSEC-2024-0021

Also known as: GHSA-4v52-7q2x-v4xj

Summary

Parts of Report are dropped as the wrong type during downcast

Details

In affected versions, after a Report is constructed using wrap_err or
wrap_err_with to attach a message of type D onto an error of type E, then
using downcast to recover ownership of either the value of type D or the
value of type E, one of two things can go wrong:

  • If downcasting to E, there remains a value of type D to be dropped. It is incorrectly "dropped" by running E's drop behavior, rather than D's. For example if D is &str and E is std::io::Error, there would be a call of std::io::Error::drop in which the reference received by the Drop impl does not refer to a valid value of type std::io::Error, but instead to &str.
  • If downcasting to D, there remains a value of type E to be dropped. When D and E do not happen to be the same size, E's drop behavior is incorrectly executed in the wrong location. The reference received by the Drop impl may point left or right of the real E value that is meant to be getting dropped.

In both cases, when the Report contains an error E that has nontrivial drop
behavior, the most likely outcome is memory corruption.

When the Report contains an error E that has trivial drop behavior (for
example a Utf8Error) but where D has nontrivial drop behavior (such as
String), the most likely outcome is that downcasting to E would leak D.

Severity

Not rated by the source.

Dates

Published
2024-03-05 12:00 UTC
Modified
2024-07-15 22:00 UTC

Affected packages and fixes

eyre

crates.io · All systems

Affected

  • introduced 0.6.9, fixed 0.6.12 (semver)

Fixed versions

0.6.12

Fix

  • Fixed version 0.6.12
    cargo update -p eyre --precise 0.6.12

Fix commands are the export's own generic commands. Ojuju never runs them. Check them against your setup first.

Check your own computer: guard packages check

View this record on OSV.dev

Source

Source: RustSec Advisory Database · CC0-1.0

Sources & licences