stack_collections
Affected
- introduced
0.3.0, fixed0.3.3(semver)
Fixed versions
0.3.3
Fix
- Fixed version
0.3.3cargo update -p stack_collections --precise 0.3.3
Advisory
Also known as: None
Double free in StackVec::retain when a predicate or element Drop panics
Summary
StackVec::retain committed its new length to self.len only after
its internal loop completed. If the retain predicate or a removed
element's Drop implementation panicked before the loop finished,
unwinding proceeded with self.len still equal to the original,
pre-retain length, leaving either a duplicated or already-destroyed
element inside 0..len. StackVec's own Drop then revisited that
slot, causing a double-drop (and for heap-owning types, a double-free).
Impact
Affects StackVec<T, CAP>::retain for T: Drop types where the
predicate or the removed element's destructor can panic, on builds
with unwinding enabled (panic = "unwind"). no_std/panic = "abort"
builds cannot trigger this, since unwinding never occurs.
Patch
Fixed in 0.3.3 using an unwind-safe backshift guard, matching the
approach alloc::vec::Vec::retain uses.
Not rated by the source.
0.3.0, fixed 0.3.3 (semver)0.3.3
0.3.3cargo update -p stack_collections --precise 0.3.3Fix commands are the export's own generic commands. Ojuju never runs them. Check them against your setup first.
Check your own computer: guard packages check
Source: RustSec Advisory Database · CC0-1.0