Advisory
UBUNTU-CVE-2024-56788
Also known as: CVE-2024-56788
Summary
The record has no summary.
Details
In the Linux kernel, the following vulnerability has been resolved: net: ethernet: oa_tc6: fix tx skb race condition between reference pointers There are two skb pointers to manage tx skb's enqueued from n/w stack. waiting_tx_skb pointer points to the tx skb which needs to be processed and ongoing_tx_skb pointer points to the tx skb which is being processed. SPI thread prepares the tx data chunks from the tx skb pointed by the ongoing_tx_skb pointer. When the tx skb pointed by the ongoing_tx_skb is processed, the tx skb pointed by the waiting_tx_skb is assigned to ongoing_tx_skb and the waiting_tx_skb pointer is assigned with NULL. Whenever there is a new tx skb from n/w stack, it will be assigned to waiting_tx_skb pointer if it is NULL. Enqueuing and processing of a tx skb handled in two different threads. Consider a scenario where the SPI thread processed an ongoing_tx_skb and it moves next tx skb from waiting_tx_skb pointer to ongoing_tx_skb pointer without doing any NULL check. At this time, if the waiting_tx_skb pointer is NULL then ongoing_tx_skb pointer is also assigned with NULL. After that, if a new tx skb is assigned to waiting_tx_skb pointer by the n/w stack and there is a chance to overwrite the tx skb pointer with NULL in the SPI thread. Finally one of the tx skb will be left as unhandled, resulting packet missing and memory leak. - Consider the below scenario where the TXC reported from the previous transfer is 10 and ongoing_tx_skb holds an tx ethernet frame which can be transported in 20 TXCs and waiting_tx_skb is still NULL. tx_credits = 10; /* 21 are filled in the previous transfer */ ongoing_tx_skb = 20; waiting_tx_skb = NULL; /* Still NULL */ - So, (tc6->ongoing_tx_skb || tc6->waiting_tx_skb) becomes true. - After oa_tc6_prepare_spi_tx_buf_for_tx_skbs() ongoing_tx_skb = 10; waiting_tx_skb = NULL; /* Still NULL */ - Perform SPI transfer. - Process SPI rx buffer to get the TXC from footers. - Now let's assume previously filled 21 TXCs are freed so we are good to transport the next remaining 10 tx chunks from ongoing_tx_skb. tx_credits = 21; ongoing_tx_skb = 10; waiting_tx_skb = NULL; - So, (tc6->ongoing_tx_skb || tc6->waiting_tx_skb) becomes true again. - In the oa_tc6_prepare_spi_tx_buf_for_tx_skbs() ongoing_tx_skb = NULL; waiting_tx_skb = NULL; - Now the below bad case might happen, Thread1 (oa_tc6_start_xmit) Thread2 (oa_tc6_spi_thread_handler) --------------------------- ----------------------------------- - if waiting_tx_skb is NULL - if ongoing_tx_skb is NULL - ongoing_tx_skb = waiting_tx_skb - waiting_tx_skb = skb - waiting_tx_skb = NULL ... - ongoing_tx_skb = NULL - if waiting_tx_skb is NULL - waiting_tx_skb = skb To overcome the above issue, protect the moving of tx skb reference from waiting_tx_skb pointer to ongoing_tx_skb pointer and assigning new tx skb to waiting_tx_skb pointer, so that the other thread can't access the waiting_tx_skb pointer until the current thread completes moving the tx skb reference safely.
Severity
Medium Basis: CVSS v3 score 4.7, vector CVSS:3.1/AV:L/AC:H/PR:L/UI:N/S:U/C:N/I:N/A:H
Dates
- Published
- 2025-01-11 13:15 UTC
- Modified
- 2026-11-12 17:24 UTC
Affected packages and fixes
| Package | System | Fix |
|---|---|---|
| linux-hwe-edge | Debian packages (deb) · Ubuntu 16.04 | No fixed version is listed. |
| linux-aws-5.0 | Debian packages (deb) · Ubuntu 18.04 | No fixed version is listed. |
| linux-aws-5.3 | Debian packages (deb) · Ubuntu 18.04 | No fixed version is listed. |
| linux-azure | Debian packages (deb) · Ubuntu 18.04 | No fixed version is listed. |
| linux-azure-5.3 | Debian packages (deb) · Ubuntu 18.04 | No fixed version is listed. |
| linux-azure-edge | Debian packages (deb) · Ubuntu 18.04 | No fixed version is listed. |
| linux-gcp | Debian packages (deb) · Ubuntu 18.04 | No fixed version is listed. |
| linux-gcp-5.3 | Debian packages (deb) · Ubuntu 18.04 | No fixed version is listed. |
| linux-gke-4.15 | Debian packages (deb) · Ubuntu 18.04 | No fixed version is listed. |
| linux-gke-5.4 | Debian packages (deb) · Ubuntu 18.04 | No fixed version is listed. |
| linux-gkeop-5.4 | Debian packages (deb) · Ubuntu 18.04 | No fixed version is listed. |
| linux-hwe | Debian packages (deb) · Ubuntu 18.04 | No fixed version is listed. |
| linux-hwe-edge | Debian packages (deb) · Ubuntu 18.04 | No fixed version is listed. |
| linux-oem | Debian packages (deb) · Ubuntu 18.04 | No fixed version is listed. |
| linux-oracle-5.0 | Debian packages (deb) · Ubuntu 18.04 | No fixed version is listed. |
| linux-oracle-5.3 | Debian packages (deb) · Ubuntu 18.04 | No fixed version is listed. |
| linux-aws-5.11 | Debian packages (deb) · Ubuntu 20.04 | No fixed version is listed. |
| linux-aws-5.13 | Debian packages (deb) · Ubuntu 20.04 | No fixed version is listed. |
| linux-aws-5.8 | Debian packages (deb) · Ubuntu 20.04 | No fixed version is listed. |
| linux-azure-5.11 | Debian packages (deb) · Ubuntu 20.04 | No fixed version is listed. |
| linux-azure-5.13 | Debian packages (deb) · Ubuntu 20.04 | No fixed version is listed. |
| linux-azure-5.8 | Debian packages (deb) · Ubuntu 20.04 | No fixed version is listed. |
| linux-azure-fde | Debian packages (deb) · Ubuntu 20.04 | No fixed version is listed. |
| linux-gcp-5.11 | Debian packages (deb) · Ubuntu 20.04 | No fixed version is listed. |
| linux-gcp-5.13 | Debian packages (deb) · Ubuntu 20.04 | No fixed version is listed. |
| linux-gcp-5.8 | Debian packages (deb) · Ubuntu 20.04 | No fixed version is listed. |
| linux-gke | Debian packages (deb) · Ubuntu 20.04 | No fixed version is listed. |
| linux-gke-5.15 | Debian packages (deb) · Ubuntu 20.04 | No fixed version is listed. |
| linux-gkeop | Debian packages (deb) · Ubuntu 20.04 | No fixed version is listed. |
| linux-gkeop-5.15 | Debian packages (deb) · Ubuntu 20.04 | No fixed version is listed. |
| linux-hwe-5.11 | Debian packages (deb) · Ubuntu 20.04 | No fixed version is listed. |
| linux-hwe-5.13 | Debian packages (deb) · Ubuntu 20.04 | No fixed version is listed. |
| linux-hwe-5.8 | Debian packages (deb) · Ubuntu 20.04 | No fixed version is listed. |
| linux-intel-5.13 | Debian packages (deb) · Ubuntu 20.04 | No fixed version is listed. |
| linux-oem-5.10 | Debian packages (deb) · Ubuntu 20.04 | No fixed version is listed. |
| linux-oem-5.13 | Debian packages (deb) · Ubuntu 20.04 | No fixed version is listed. |
| linux-oem-5.14 | Debian packages (deb) · Ubuntu 20.04 | No fixed version is listed. |
| linux-oem-5.6 | Debian packages (deb) · Ubuntu 20.04 | No fixed version is listed. |
| linux-oracle-5.11 | Debian packages (deb) · Ubuntu 20.04 | No fixed version is listed. |
| linux-oracle-5.13 | Debian packages (deb) · Ubuntu 20.04 | No fixed version is listed. |
| linux-oracle-5.8 | Debian packages (deb) · Ubuntu 20.04 | No fixed version is listed. |
| linux-raspi2 | Debian packages (deb) · Ubuntu 20.04 | No fixed version is listed. |
| linux-riscv | Debian packages (deb) · Ubuntu 20.04 | No fixed version is listed. |
| linux-riscv-5.11 | Debian packages (deb) · Ubuntu 20.04 | No fixed version is listed. |
| linux-riscv-5.8 | Debian packages (deb) · Ubuntu 20.04 | No fixed version is listed. |
| linux-allwinner-5.19 | Debian packages (deb) · Ubuntu 22.04 | No fixed version is listed. |
| linux-aws-5.19 | Debian packages (deb) · Ubuntu 22.04 | No fixed version is listed. |
| linux-aws-6.2 | Debian packages (deb) · Ubuntu 22.04 | No fixed version is listed. |
| linux-aws-6.5 | Debian packages (deb) · Ubuntu 22.04 | No fixed version is listed. |
| linux-azure-5.19 | Debian packages (deb) · Ubuntu 22.04 | No fixed version is listed. |
| linux-azure-6.2 | Debian packages (deb) · Ubuntu 22.04 | No fixed version is listed. |
| linux-azure-6.5 | Debian packages (deb) · Ubuntu 22.04 | No fixed version is listed. |
| linux-azure-fde-5.19 | Debian packages (deb) · Ubuntu 22.04 | No fixed version is listed. |
| linux-azure-fde-6.2 | Debian packages (deb) · Ubuntu 22.04 | No fixed version is listed. |
| linux-gcp-5.19 | Debian packages (deb) · Ubuntu 22.04 | No fixed version is listed. |
| linux-gcp-6.2 | Debian packages (deb) · Ubuntu 22.04 | No fixed version is listed. |
| linux-gcp-6.5 | Debian packages (deb) · Ubuntu 22.04 | No fixed version is listed. |
| linux-hwe-5.19 | Debian packages (deb) · Ubuntu 22.04 | No fixed version is listed. |
| linux-hwe-6.2 | Debian packages (deb) · Ubuntu 22.04 | No fixed version is listed. |
| linux-hwe-6.5 | Debian packages (deb) · Ubuntu 22.04 | No fixed version is listed. |
| linux-intel-iot-realtime | Debian packages (deb) · Ubuntu 22.04 | No fixed version is listed. |
| linux-lowlatency-hwe-5.19 | Debian packages (deb) · Ubuntu 22.04 | No fixed version is listed. |
| linux-lowlatency-hwe-6.2 | Debian packages (deb) · Ubuntu 22.04 | No fixed version is listed. |
| linux-lowlatency-hwe-6.5 | Debian packages (deb) · Ubuntu 22.04 | No fixed version is listed. |
| linux-nvidia-6.2 | Debian packages (deb) · Ubuntu 22.04 | No fixed version is listed. |
| linux-nvidia-6.5 | Debian packages (deb) · Ubuntu 22.04 | No fixed version is listed. |
| linux-oem-5.17 | Debian packages (deb) · Ubuntu 22.04 | No fixed version is listed. |
| linux-oem-6.0 | Debian packages (deb) · Ubuntu 22.04 | No fixed version is listed. |
| linux-oem-6.1 | Debian packages (deb) · Ubuntu 22.04 | No fixed version is listed. |
| linux-oem-6.5 | Debian packages (deb) · Ubuntu 22.04 | No fixed version is listed. |
| linux-oracle-6.5 | Debian packages (deb) · Ubuntu 22.04 | No fixed version is listed. |
| linux-realtime | Debian packages (deb) · Ubuntu 22.04 | No fixed version is listed. |
| linux-riscv | Debian packages (deb) · Ubuntu 22.04 | No fixed version is listed. |
| linux-riscv-5.19 | Debian packages (deb) · Ubuntu 22.04 | No fixed version is listed. |
| linux-riscv-6.5 | Debian packages (deb) · Ubuntu 22.04 | No fixed version is listed. |
| linux-starfive-5.19 | Debian packages (deb) · Ubuntu 22.04 | No fixed version is listed. |
| linux-starfive-6.2 | Debian packages (deb) · Ubuntu 22.04 | No fixed version is listed. |
| linux-starfive-6.5 | Debian packages (deb) · Ubuntu 22.04 | No fixed version is listed. |
| linux-azure-6.11 | Debian packages (deb) · Ubuntu 24.04 | No fixed version is listed. |
| linux-gcp-6.11 | Debian packages (deb) · Ubuntu 24.04 | No fixed version is listed. |
| linux-hwe-6.11 | Debian packages (deb) · Ubuntu 24.04 | No fixed version is listed. |
| linux-intel | Debian packages (deb) · Ubuntu 24.04 | No fixed version is listed. |
| linux-lowlatency-hwe-6.11 | Debian packages (deb) · Ubuntu 24.04 | No fixed version is listed. |
| linux-nvidia-6.11 | Debian packages (deb) · Ubuntu 24.04 | No fixed version is listed. |
| linux-oem-6.11 | Debian packages (deb) · Ubuntu 24.04 | No fixed version is listed. |
| linux-oem-6.8 | Debian packages (deb) · Ubuntu 24.04 | No fixed version is listed. |
| linux-raspi-realtime | Debian packages (deb) · Ubuntu 24.04 | No fixed version is listed. |
| linux-realtime | Debian packages (deb) · Ubuntu 24.04 | No fixed version is listed. |
| linux-riscv | Debian packages (deb) · Ubuntu 24.04 | No fixed version is listed. |
Fix commands are the export's own generic commands. Ojuju never runs them. Check them against your setup first.
Check your own computer: guard packages check
Links
- https://ubuntu.com/security/CVE-2024-56788
- https://www.cve.org/CVERecord?id=CVE-2024-56788
- https://git.kernel.org/linus/e592b5110b3e9393881b0a019d86832bbf71a47f
- https://git.kernel.org/stable/c/1f2eb6c32bae04b375bb7a0aedbeefb6dbbcb775
- https://git.kernel.org/stable/c/e592b5110b3e9393881b0a019d86832bbf71a47f
Source
Source: Ubuntu Security Notices · CC BY-SA 4.0