Details
Impact
- Gym Management Lockout: A trainer can deactivate every manager account in their gym, effectively seizing control of the gym's administrative functions.
- Denial of Service: Deactivated managers cannot log in, manage members, or perform any administrative tasks until a
general_gym_manager(superadmin) or a Django superuser manually re-activates their accounts. - Abuse Chain: Since
get_permission_list()always includes'trainer'in assignable roles, any manager can unknowingly create the account that will later lock them out.
Fix
Add a privilege hierarchy check in UserDeactivateView.dispatch() and UserActivateView.dispatch():
# File: wger/core/views/user.py, inside dispatch() of both views
edit_user = get_object_or_404(User, pk=self.kwargs['pk'])
# Trainers must not deactivate/activate managers or other trainers
if request.user.has_perm('gym.gym_trainer') and not (
request.user.has_perm('gym.manage_gym')
or request.user.has_perm('gym.manage_gyms')
):
if (
edit_user.has_perm('gym.manage_gym')
or edit_user.has_perm('gym.manage_gyms')
or edit_user.has_perm('gym.gym_trainer')
):
return HttpResponseForbidden()